Don't report CancellationError from BookmarksFaviconsFetcher #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
approved these changes
Jan 26, 2024
samsymons
added a commit
that referenced
this pull request
Feb 8, 2024
* main: add alternateHtmlLoad navigation type (HTML Error Page) (#644) Check subfeature state before reading rollout data (#649) Add NavigationPreferences CustomHeaderFields (#651) Update autofill to 10.1.0 (#643) Add Autoconsent onByDefault subfeature (#647) Add error codes to site breakage reports (#642) Run unit tests also on iOS Simulator (#641) Improve VPN auth token storage (#639) Bump content-scope-scripts to 4.59.2 (#638) Fix `site:` queries escaping with iOS 17 SDK (#640) Breakage improvement (#621) Don't report CancellationError from BookmarksFaviconsFetcher (#634) Add explicit mapping of SyncError to error code (#637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1201493110486074/1206407973669779/f
iOS PR: duckduckgo/iOS#2385
macOS PR: duckduckgo/macos-browser#2120
What kind of version bump will this require?: Patch
Optional:
CC: @bwaresiak
Description:
Keep cancelling operations when requested, but without reporting the cancellation
to errorEvents, which could have caused them being reported as Pixels.
Steps to test this PR:
throw CancellationError()e.g. in line 122 ofFaviconsFetchOperation.swiftOS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template