Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autoconsent onByDefault subfeature #647

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Feb 1, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1206474382370291/f
iOS PR: duckduckgo/iOS#2423
macOS PR: duckduckgo/macos-browser#2140
What kind of version bump will this require?: Minor

Description:

Adds onByDefault subfeature for autoconsent, allowing to roll out the new default setting incrementally on iOS.

Steps to test this PR:
No changes in existing behavior. Subfeature will be used in duckduckgo/iOS#2373

@dus7 dus7 self-assigned this Feb 1, 2024
@dus7 dus7 marked this pull request as ready for review February 1, 2024 09:30
@federicocappelli federicocappelli self-requested a review February 1, 2024 09:34
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dus7 dus7 merged commit 537dc46 into main Feb 1, 2024
17 checks passed
@dus7 dus7 deleted the mariusz/add-autoconsent-subfeature branch February 1, 2024 09:44
samsymons added a commit that referenced this pull request Feb 8, 2024
* main:
  add alternateHtmlLoad navigation type (HTML Error Page) (#644)
  Check subfeature state before reading rollout data (#649)
  Add NavigationPreferences CustomHeaderFields (#651)
  Update autofill to 10.1.0 (#643)
  Add Autoconsent onByDefault subfeature (#647)
  Add error codes to site breakage reports (#642)
  Run unit tests also on iOS Simulator (#641)
  Improve VPN auth token storage (#639)
  Bump content-scope-scripts to 4.59.2 (#638)
  Fix `site:` queries escaping with iOS 17 SDK (#640)
  Breakage improvement (#621)
  Don't report CancellationError from BookmarksFaviconsFetcher (#634)
  Add explicit mapping of SyncError to error code (#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants