Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alternateHtmlLoad navigation type (HTML Error Page) #644

Merged
merged 11 commits into from
Feb 7, 2024

Conversation

mallexxx
Copy link
Collaborator

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/72649045549333/1203487090719123/f
iOS PR: - not affected
macOS PR:
What kind of version bump will this require?: Minor

Description:

  • Added alternateHtmlLoad navigation type for html error page navigations using webView._loadAlternateHtml

Steps to test this PR:

  1. Validate error page navigations have alternateHtmlLoad, Tab.error is not reset on these navigations and no assertions raised

OS Testing:

  • macOS

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

mallexxx added a commit that referenced this pull request Feb 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206426619289877/f
iOS PR: not affected
macOS PR: duckduckgo/macos-browser#2147

Includes  #644 changes except Content-Scope-Scripts rev change: 
Task/Issue URL: https://app.asana.com/0/72649045549333/1203487090719123/f
iOS PR: - not affected
@mallexxx
Copy link
Collaborator Author

mallexxx commented Feb 7, 2024

Changes from this PR have been merged to #651 except the CSS rev change

@mallexxx mallexxx merged commit 51b5d28 into main Feb 7, 2024
7 checks passed
@mallexxx mallexxx deleted the alex/add-alternate-html-navigation-type branch February 7, 2024 10:01
samsymons added a commit that referenced this pull request Feb 8, 2024
* main:
  add alternateHtmlLoad navigation type (HTML Error Page) (#644)
  Check subfeature state before reading rollout data (#649)
  Add NavigationPreferences CustomHeaderFields (#651)
  Update autofill to 10.1.0 (#643)
  Add Autoconsent onByDefault subfeature (#647)
  Add error codes to site breakage reports (#642)
  Run unit tests also on iOS Simulator (#641)
  Improve VPN auth token storage (#639)
  Bump content-scope-scripts to 4.59.2 (#638)
  Fix `site:` queries escaping with iOS 17 SDK (#640)
  Breakage improvement (#621)
  Don't report CancellationError from BookmarksFaviconsFetcher (#634)
  Add explicit mapping of SyncError to error code (#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants