Add NavigationPreferences CustomHeaderFields #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
github-actions
bot
added
the
bot: not in app board
github-actions
bot
removed
the
bot: not in app board
tomasstrba
approved these changes
Feb 6, 2024
mallexxx
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1206426619289877/f iOS PR: not affected macOS PR: duckduckgo/macos-browser#2147 Includes #644 changes except Content-Scope-Scripts rev change: Task/Issue URL: https://app.asana.com/0/72649045549333/1203487090719123/f iOS PR: - not affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206426619289877/f
BSK PR: duckduckgo/BrowserServicesKit#651
Description:
Steps to test this PR:
X-DuckDuckGo-Clientheader is passed to SERP (e.g. by adding|| navigationAction.url.host == "myhttpheader.comatSerpHeadersNavigationResponder.swift:30and navigating to https://myhttpheader.com/Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation