Password Manager widget and app shortcut #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-mgr-shortcut # Conflicts: # DuckDuckGo/AppDelegate.swift # Widgets/WidgetViews.swift
amddg44
changed the title
github-actions
bot
added
the
bot: not in app board
amddg44
removed
the
bot: not in app board
aataraxiaa
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Validated and working as expected. Looks really awesome @amddg44, nice job! 🚀 Just left too super minor suggestions.
| @@ -349,6 +356,20 @@ final class AutofillLoginSettingsListViewController: UIViewController { | |||
| } | |||
| } | |||
|
|
|||
| private func openSearchIfRequired() { | |||
| // Don't auto open search if user has selected an account | |||
| if selectedAccount != nil { | |||
There was a problem hiding this comment.
Super minor suggestion - If you preferred, we could use a guard here, e.g:
Suggested change
| if selectedAccount != nil { | |
| guard selectedAccount == nil else { return } |
Widgets/WidgetViews.swift
Outdated
|
|
||
| VStack(alignment: .center, spacing: 14) { | ||
|
|
||
| Image("WidgetPasswordIllustration") |
There was a problem hiding this comment.
Suggested change
| Image("WidgetPasswordIllustration") | |
| Image(.widgetPasswordIllustration) |
Think you could use that here (and other places too if so inclined)
samsymons
added a commit
that referenced
this pull request
Apr 12, 2024
# By Mariusz Śpiewak (4) and others # Via Chris Brind (1) and others * main: Reverting accidental push to main (#2718) Add SubscriptionContainerViewModel and Manually hide loader + Pixel (#2687) Release 7.115.0-2 (#2712) soft revert history suggestions (#2711) Bring back accessibility identifiers for onboarding buttons (#2709) BSK release 133.1.0 (#2708) Password Manager widget and app shortcut (#2619) Release 7.115.0-1 (#2707) Update set-as-default onboarding illustration for dark mode (#2694) update app store prompt logic (#2678) Fix status bar color on regular width size class (#2705) Updated settings (#2603) Update BSK with autofill 11.0.1 (#2704) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/42792087274227/1206508535741153/f
Tech Design URL:
CC:
Description:
Adds home screen widget, lock screen widget & app shortcut to quickly access passwords
Steps to test this PR:
Search PasswordsCopy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template