Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update app store prompt logic #2678

Merged
merged 7 commits into from
Apr 10, 2024
Merged

update app store prompt logic #2678

merged 7 commits into from
Apr 10, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 4, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1206657927397548/f
Tech Design URL:
CC:

Description:

Updates the logic for showing the App Store prompt:

  • Only triggers on SERP
  • Only triggers the first time on or after the 3rd day of actual usage
  • Only triggers the second time when 4 or more days of actual usage have passed

Steps to test this PR:

  1. Clean install, run the app and go to the SERP - no prompt visible
  2. In the code edit AppRatingPrompt.uniqueAccessDays property to return 3
  3. Add a breakpoint to the setter of that property
  4. Go to the SERP - should prompt for review, confirm that uniqueAccessDays was reset to 0
  5. In the code edit unique AppRatingPrompt.uniqueAccessDays property to return 0
  6. Go to the SERP - should NOT prompt for review
  7. In the code edit unique AppRatingPrompt.uniqueAccessDays property to return 4
  8. Go to the SERP - should prompt for review
  9. In the code edit unique AppRatingPrompt.uniqueAccessDays property to return 0
  10. Go to the SERP - should NOT prompt for review
  11. In the code edit unique AppRatingPrompt.uniqueAccessDays property to return 4
  12. Go to the SERP - should NOT prompt for review

@brindy brindy marked this pull request as ready for review April 5, 2024 09:04
@brindy brindy requested review from a team and jaceklyp and removed request for a team April 5, 2024 09:07
bwaresiak
bwaresiak approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@brindy brindy merged commit 9d21a6f into main Apr 10, 2024
13 checks passed
@brindy brindy deleted the brindy/update-app-store-prompt-logic branch April 10, 2024 11:53
samsymons added a commit that referenced this pull request Apr 12, 2024
@samsymons
Merge branch 'main' into sam/remove-tzoffset
0e15e7b 
# By Mariusz Śpiewak (4) and others
# Via Chris Brind (1) and others
* main:
  Reverting accidental push to main (#2718)
  Add SubscriptionContainerViewModel and
  Manually hide loader + Pixel (#2687)
  Release 7.115.0-2 (#2712)
  soft revert history suggestions (#2711)
  Bring back accessibility identifiers for onboarding buttons (#2709)
  BSK release 133.1.0 (#2708)
  Password Manager widget and app shortcut (#2619)
  Release 7.115.0-1 (#2707)
  Update set-as-default onboarding illustration for dark mode (#2694)
  update app store prompt logic (#2678)
  Fix status bar color on regular width size class (#2705)
  Updated settings (#2603)
  Update BSK with autofill 11.0.1 (#2704)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

@jaceklyp jaceklyp Awaiting requested review from jaceklyp jaceklyp was automatically assigned from duckduckgo/apple-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @bwaresiak