Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kingfisher deprecation warnings #2799

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1207185436384594/f
Tech Design URL:
CC:

Description:

This PR fixes Kingfisher deprecation warnings.

These appear on every PR, like this one, where you can see a list of warnings at the bottom of the diff.

Steps to test this PR:

  1. Check that favicon fetching works (favourite a web page and check that its favicon appears in the new tab page)
  2. Check that there are no warnings related to Kingfisher either in Xcode or here in the PR diff

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested review from a team and federicocappelli and removed request for a team April 27, 2024 18:45
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@samsymons samsymons merged commit 5e52e8d into main Apr 30, 2024
13 checks passed
@samsymons samsymons deleted the sam/fix-kingfisher-deprecation-warning branch April 30, 2024 14:33
samsymons added a commit that referenced this pull request Apr 30, 2024
* main:
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)
samsymons added a commit that referenced this pull request May 1, 2024
* main:
  Release 7.118.0-1 (#2812)
  [Release PR] Update VPN metadata reporter (#2808)
  fix address bar weirdness (#2810)
  Fix RMF button styling for "big_two_action" format (#2811)
  Existing experiment disabled, the new Settings experiment activated (#2801)
  Create Asana Subtask on PR requested (#2803)
  Remove ATB from default params (#2430)
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)
  Disable the feedback send button when there’s no text (#2800)
samsymons added a commit that referenced this pull request May 1, 2024
# By Sam Symons (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Release 7.118.0-1 (#2812)
  [Release PR] Update VPN metadata reporter (#2808)
  fix address bar weirdness (#2810)
  Fix RMF button styling for "big_two_action" format (#2811)
  Existing experiment disabled, the new Settings experiment activated (#2801)
  Create Asana Subtask on PR requested (#2803)
  Remove ATB from default params (#2430)
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants