Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RMF button styling for "big_two_action" format #2811

Merged
merged 3 commits into from
May 1, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented May 1, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1207213363644901/f
Tech Design URL:
CC:

Description:
Corrects button styling for remote messages with 2 buttons

Steps to test this PR:

  1. Update the debug URL in RemoteMessageRequest to be https://www.jsonblob.com/api/1234544668208652288
  2. Launch the app and run through the remote messages and confirm that they all display correctly (quit & re-launch the app after dismissing each message to see the next one)

image

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label May 1, 2024
@amddg44 amddg44 requested a review from brindy May 1, 2024 13:49
@amddg44 amddg44 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label May 1, 2024
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amddg44 amddg44 merged commit 7e308d1 into release/7.118.0 May 1, 2024
21 of 23 checks passed
@amddg44 amddg44 deleted the anya/fix-rmf-button-styling branch May 1, 2024 14:20
samsymons added a commit that referenced this pull request May 1, 2024
* main:
  Release 7.118.0-1 (#2812)
  [Release PR] Update VPN metadata reporter (#2808)
  fix address bar weirdness (#2810)
  Fix RMF button styling for "big_two_action" format (#2811)
  Existing experiment disabled, the new Settings experiment activated (#2801)
  Create Asana Subtask on PR requested (#2803)
  Remove ATB from default params (#2430)
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)
  Disable the feedback send button when there’s no text (#2800)
samsymons added a commit that referenced this pull request May 1, 2024
# By Sam Symons (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Release 7.118.0-1 (#2812)
  [Release PR] Update VPN metadata reporter (#2808)
  fix address bar weirdness (#2810)
  Fix RMF button styling for "big_two_action" format (#2811)
  Existing experiment disabled, the new Settings experiment activated (#2801)
  Create Asana Subtask on PR requested (#2803)
  Remove ATB from default params (#2430)
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants