Logging refactoring phase #2 #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
federicocappelli
changed the title
afterxleep
reviewed
Aug 23, 2024
| @@ -213,7 +213,7 @@ final class DuckPlayer: DuckPlayerProtocol { | |||
| let isPiPEnabled = webView?.configuration.allowsPictureInPictureMediaPlayback == true | |||
| let pip = InitialPlayerSettings.PIP(status: isPiPEnabled ? .enabled : .disabled) | |||
| let platform = InitialPlayerSettings.Platform(name: "ios") | |||
| let environment = InitialPlayerSettings.Environment.development | |||
| // let environment = InitialPlayerSettings.Environment.development | |||
There was a problem hiding this comment.
Thanks for cleaning this warning. This will be removed soon
afterxleep
approved these changes
Aug 23, 2024
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # Core/Pixel.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 28, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206750146033742/f iOS PR: duckduckgo/iOS#3268 macOS PR: TBC What kind of version bump will this require?: Major Tech Design URL: https://app.asana.com/0/1200194497630846/1206777133329590/f **Description**: Now logging is aligned to our guideline: https://app.asana.com/0/1202500774821704/1208001254061393/f - all OSLog wrappers removed - all os_log uses removed and replaced with Logger - ability to disable logs from the app removed - Local and shared Logger improved
samsymons
added a commit
that referenced
this pull request
Aug 29, 2024
# By Daniel Bernal (4) and others # Via Bartek Waresiak (2) and others * main: (32 commits) Add error pixels for Subscription keychain access errors (#3276) [DuckPlayer] 24. FrontEnd Translation (#3281) [DuckPlayer] 23. Ship Review Fixes (#3279) Logging refactoring phase #2 (#3268) Move WireGuard dependency to packet tunnel provider (#3273) Add PPro unified feedback form (#3248) disable flaky test (#3283) Unified feedback form for Privacy Pro (#3172) Release 7.135.0-1 (#3280) fix back forward swipe gesture in landscape (#3278) Set onboarding completed for sync end to end tests (#3259) Release 7.135.0-0 (#3277) BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275) Fix math expressions on address bar (#3262) fix progress view crash by removing call to flush (#3272) Update autoconsent to v10.15.0 (#3254) Mitigate Onboarding pixels firing with empty atb (#3265) Clean up legacy VPN navigation (#3266) Re-Enable Broken Site Toast on iOS (#3244) Bump BSK (No iOS Changes) (#3261) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206750146033742/f
Tech Design URL: https://app.asana.com/0/1200194497630846/1206777133329590/f
CC: @samsymons @diegoreymendez
Description:
Now logging is aligned with our guideline: https://app.asana.com/0/1202500774821704/1208001254061393/f
Internal references:
Software Engineering Expectations
Technical Design Template