Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DuckPlayer] 24. FrontEnd Translation #3281

Merged
merged 6 commits into from
Aug 28, 2024
Merged

[DuckPlayer] 24. FrontEnd Translation #3281

merged 6 commits into from
Aug 28, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Aug 27, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208149666429213/f

Description:

  • Translates Duckplayer FrontEnd and updates copy based on Ship Review
  • Removes copy from DP footer in settings
  • Updates Copy for DuckPlayer Prompt and Settings to be new, and the same

Steps to test this PR:

  1. Make yourself internal
  2. Add custom config with: https://www.jsonblob.com/api/1276215786342309888
  3. Enable Duck Player in ask mode
  4. Change app language
  5. Go to youtube and Open a video
  6. Confirm FE is translated.
  7. Go to "Settings" for Duck Player.
  8. Confirm there is no footer in the only cell in the table
  9. Check copy for DP modal and settings

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 2f85009

@afterxleep afterxleep marked this pull request as ready for review August 27, 2024 14:55
@afterxleep afterxleep requested a review from Bunn August 27, 2024 15:20
Bunn
Bunn approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, translation issue commented on the task

@afterxleep afterxleep merged commit fc0ea9b into main Aug 28, 2024
13 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer/24.locales branch August 28, 2024 12:38
samsymons added a commit that referenced this pull request Aug 29, 2024
@samsymons
Merge branch 'main' into diego/domain-exclusion-improvements
fb16ec6 
# By Daniel Bernal (4) and others
# Via Bartek Waresiak (2) and others
* main: (32 commits)
  Add error pixels for Subscription keychain access errors (#3276)
  [DuckPlayer] 24. FrontEnd Translation (#3281)
  [DuckPlayer] 23. Ship Review Fixes (#3279)
  Logging refactoring phase #2 (#3268)
  Move WireGuard dependency to packet tunnel provider (#3273)
  Add PPro unified feedback form (#3248)
  disable flaky test (#3283)
  Unified feedback form for Privacy Pro (#3172)
  Release 7.135.0-1 (#3280)
  fix back forward swipe gesture in landscape (#3278)
  Set onboarding completed for sync end to end tests (#3259)
  Release 7.135.0-0 (#3277)
  BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275)
  Fix math expressions on address bar (#3262)
  fix progress view crash by removing call to flush (#3272)
  Update autoconsent to v10.15.0 (#3254)
  Mitigate Onboarding pixels firing with empty atb (#3265)
  Clean up legacy VPN navigation (#3266)
  Re-Enable Broken Site Toast on iOS (#3244)
  Bump BSK (No iOS Changes) (#3261)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @Bunn