Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.139.0-4 #3411

Merged
merged 19 commits into from
Sep 27, 2024
Merged

Release 7.139.0-4 #3411

merged 19 commits into from
Sep 27, 2024

Conversation

quanganhdo
Copy link
Member

Please make sure all GH checks passed before merging. It can take around 20 minutes.
Briefly review this PR to see if there are no issues or red flags and then merge it.

dus7 and others added 19 commits September 24, 2024 11:41
Task/Issue URL:
https://app.asana.com/0/414235014887631/1207931637636063/f
Tech Design URL:
CC:

**Description**:

Trigger add-task-to-project when PR marked ready for review.

Counterpart of duckduckgo/macos-browser#3273.

**Steps to test this PR**:

* Create a copy of this branch and open a draft PR. 
* Mark as ready for review and check if the "Add Task to App Board
Project" action is successful.

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
Task/Issue URL:
https://app.asana.com/0/414709148257752/1208380046395184/f
Tech Design URL:
CC:

**Description**:
Fix usage segmentation for return users.

**Steps to test this PR**:
1. Reset the simulator `xcrun simctl erase all`
2. Add the following lines to the start of the `load` func of
`StatisticsLoader`:

        statisticsStore.variant = "ru"
        statisticsStore.atb = "v446-1"
        statisticsStore.appRetentionAtb = "v447-1"
        statisticsStore.searchRetentionAtb = "v447-2"

4. Run the app and check for a pixel like this:

Pixel fired m.retention.segments ["count_as_mau_n": "tttt",
"new_set_atb": "v448-7", "count_as_wau": "true", "segments_today":
"first_month,reactivated_wau,reinstaller", "activity_type": "app_use"]

5. Ensure that `reinstaller` and `"activity_type": "app_use"` are in the
parameters as above
6. Get through onboarding and do a search
7. Check for a similar pixel ensuring that `reinstaller` and
`"activity_type": "search"` are in the parameters

**Definition of Done (Internal Only)**:

* [x] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
Task/Issue URL: https://app.asana.com/0/0/1208244619690577/f
Tech Design URL:
CC:

**Description**:

Removes Favorites header when no favorites present. This allowed to
removed whole EmptyStateView. Leftover function was incorporated into
`FavoritesViewModel`, allowing to remove the generic type from
`NewTabPageView`.

**Steps to test this PR**:
1. Open NTP without having any favorites, make sure there's an add
button and placeholders are visible.
2. Rotate to landscape. Verify whole row is filled up with placeholders.
3. Pixel should be fired when any placeholder is tapped. 

**Definition of Done (Internal Only)**:

* [x] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Orientation Testing**:

* [x] Portrait
* [x] Landscape
---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
This reverts commit ad720ed.
Task/Issue URL:
https://app.asana.com/0/392891325557410/1208350972189287/f
Tech Design URL:
CC: @ayoy 

**Description**:
Adds assertions that validate tabs in suggestions and switching tabs

Fixes failure check for sending notification in the workflow

**Steps to test this PR**:
1. Check this test run passes:
https://github.com/duckduckgo/iOS/actions/runs/11037282165
(However End to End tests have not passed for some time so as long as
tabs.yaml passes that is the main thing)

3. Run the release/tabs.yaml test locally
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL:
https://app.asana.com/0/72649045549333/1207836782368194/f
Tech Design URL:
https://app.asana.com/0/72649045549333/1207836782368196/f
Corresponding BSK PR:
duckduckgo/BrowserServicesKit#1006
Corresponding macOS PR:
duckduckgo/macos-browser#3347

CC: @jonathanKingston 

**Description**:
This PR bumps the BSK pin to pull in the changes from
duckduckgo/content-scope-scripts#1026.

<!--
If at any point it isn't actively being worked on/ready for
review/otherwise moving forward strongly consider closing it (or not
opening it in the first place). If you decide not to close it, use Draft
PR while work is still in progress or use `DO NOT MERGE` label to
clarify the PRs state and comment with more information.
-->

**Steps to test this PR**:
1. Navigate to any old [MSN article
page](https://www.msn.com/en-us/sports/nfl/how-saquon-barkley-gave-eagles-coach-a-hard-lesson-in-accountability-while-saving-season/ar-AA1qPl89?ocid=hpmsn&cvid=81d6bc9eb97e442ba7de62c248189b23&ei=12)
and refresh the page two or more times. See that the Expand Article
button persists across reloads.

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Copy Testing**:

* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`

**Orientation Testing**:

* [ ] Portrait
* [ ] Landscape

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

**Theme Testing**:

* [ ] Light theme
* [ ] Dark theme

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
…rst party (#3386)

Task/Issue URL:
https://app.asana.com/0/414709148257752/1208376794617030/f

**Description**:
Fixed in BSK. 
When loading a website and some of the allowed third party requests may
not be recognized as trackers but by their URL they may belong to the
same entity as the website. For that cases we should mark their state as
`.allowed(reason: .ownedByFirstParty)` (instead of `.allowed(reason:
.otherThirdPartyRequest)`).
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL:
https://app.asana.com/0/1201048563534612/1208413716679959/f
Tech Design URL:
CC:

**Description**:
Bump BSK to include suggestions performance fix.

**Steps to test this PR**:
1. see duckduckgo/BrowserServicesKit#1008

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Copy Testing**:

* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`

**Orientation Testing**:

* [ ] Portrait
* [ ] Landscape

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

**Theme Testing**:

* [ ] Light theme
* [ ] Dark theme

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
Copy link

Fails
🚫 Please, don't forget to add a link to the internal task
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 5819a6a

@quanganhdo quanganhdo merged commit 974fca1 into release/7.139.0 Sep 27, 2024
20 of 22 checks passed
@quanganhdo quanganhdo deleted the release/7.139.0-build-4 branch September 27, 2024 17:19
samsymons added a commit that referenced this pull request Sep 28, 2024
# By Daniel Bernal (12) and others
# Via Daniel Bernal (5) and others
* main: (46 commits)
  Release 7.139.0-4 (#3411)
  Onboarding highlights experiment updates (#3406)
  fix suggestions performance (#3405)
  For third party requests differentiate if they are affiliated with first party (#3386)
  Bump BSK to pull in C-S-S 6.19.0 (#3396)
  Release 7.139.0-3 (#3399)
  Onboarding Highlights Ship Review  (#3380)
  add assertions for tabs in suggestions (#3394)
  Release 7.139.0-2 (#3398)
  Bump BSK to Include C.S.S 6.17 (#3397)
  Bump BSK which includes C.S.S 6.17 (#3395)
  Rever BSK branch
  Revert "Bump C.S.S"
  Bump C.S.S
  translations for Switch to Tab (#3391)
  Remove Favorites section header from NTP (#3381)
  Release 7.139.0-1 (#3389)
  Add origin to /apps URL (#3378)
  chery pick returning user fix
  Release 7.138.1-0 (#3388)
  ...

# Conflicts:
#	DuckDuckGo/AppDependencyProvider.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants