Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Core Data usage in RemoteMessagingStore #3425

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Refactor Core Data usage in RemoteMessagingStore #3425

merged 4 commits into from
Oct 10, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Oct 10, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1201048563534612/1208493869353425/f

Description:
This change updates RMF client to use new async API from BSK's RemoteMessagingStore.

Steps to test this PR:
See BSK PR for testing steps.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Oct 10, 2024
@ayoy ayoy mentioned this pull request Oct 10, 2024
Merged
6 tasks
@ayoy ayoy force-pushed the dominik/rmf-store branch from dec6385 to 4a7aaf0 Compare October 10, 2024 12:53
@ayoy ayoy marked this pull request as ready for review October 10, 2024 13:54
@ayoy ayoy requested a review from amddg44 October 10, 2024 14:06
@ayoy ayoy assigned amddg44 and unassigned ayoy Oct 10, 2024
@ayoy ayoy merged commit 698f13f into main Oct 10, 2024
13 checks passed
@ayoy ayoy deleted the dominik/rmf-store branch October 10, 2024 20:58
samsymons added a commit that referenced this pull request Oct 10, 2024
@samsymons
Merge branch 'main' into sam/persistent-pixels
f4e380f 
* main:
  Refactor Core Data usage in RemoteMessagingStore (#3425)
  Release 7.140.0-1 (#3428)
  Updates Internal release with 7.139.1 hotfix changes (#3426)
  Disabling autocompletion for website suggestions on macOS (#3401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amddg44 amddg44 amddg44 approved these changes

Assignees

@amddg44 amddg44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @amddg44