Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling autocompletion for website suggestions on macOS #3401

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Disabling autocompletion for website suggestions on macOS #3401

merged 2 commits into from
Oct 10, 2024

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1208219569168394/f

Description:
Disabling autocompletion for website suggestions on macOS. This doesn't affect iOS

Steps to test this PR:

  1. Verify basic workflows with address bar and observe suggestions.

Definition of Done (Internal Only):

Internal references:

Software Engineering Expectations
Technical Design Template

@tomasstrba tomasstrba requested a review from brindy September 26, 2024 16:19
brindy
brindy approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Oct 4, 2024
tomasstrba added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Oct 10, 2024
@tomasstrba
Disable autocompletion for website suggestions (#1007)
c642e92 
Task/Issue URL: https://app.asana.com/0/414235014887631/1208219569168394/f
iOS PR: duckduckgo/iOS#3401
macOS PR: duckduckgo/macos-browser#3351
What kind of version bump will this require?: Major/Minor/Patch

**Description**:

Disable autocompletion for website suggestions
@tomasstrba tomasstrba removed the stale label Oct 10, 2024
@tomasstrba tomasstrba merged commit 586bf80 into main Oct 10, 2024
15 checks passed
@tomasstrba tomasstrba deleted the tom/disable-domain-suggestions branch October 10, 2024 11:55
samsymons added a commit that referenced this pull request Oct 10, 2024
@samsymons
Merge branch 'main' into sam/persistent-pixels
f4e380f 
* main:
  Refactor Core Data usage in RemoteMessagingStore (#3425)
  Release 7.140.0-1 (#3428)
  Updates Internal release with 7.139.1 hotfix changes (#3426)
  Disabling autocompletion for website suggestions on macOS (#3401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasstrba @brindy