Disable autocompletion for website suggestions #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
brindy
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM
Couldn't get it working at first, because for some reason it wasn't picking up the commit with the change in. I switched to a commit ref and used the latest one and it then started working. Better to use explicit commit refs tbh. Hopefully this BSK dance will be gone soon 🙏
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
tomasstrba
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Oct 10, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1208219569168394/f iOS PR: duckduckgo/iOS#3401 macOS PR: duckduckgo/macos-browser#3351 What kind of version bump will this require?: Major/Minor/Patch **Description**: Disable autocompletion for website suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208219569168394/f
Description:
Autocompletion (automatic selection of the first Top Hit suggestion) disabled for website suggestions.
Steps to test this PR:
bbinto the address barbbc.comwebsite suggestion is the first suggestion (or other URL alternatives), but it's NOT automatically selectedbbc.com(exactly) and wait until the website loadsbbinto the address bar againbbc.comis a first suggestion (based on history) and autocompleted (automatically selected)Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation