Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily crash pixel #3702

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add daily crash pixel #3702

merged 2 commits into from
Dec 10, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1200194497630846/1208908529122511/f
Tech Design URL:
CC:

Description:

This PR adds a daily crash pixel.

Steps to test this PR:

  1. Run this branch on a device
  2. Disconnect the debugger, then re-open the app and use the debug menu to crash the app
  3. Next, relaunch the app from Xcode so that the debugger is attached, and check that you see a daily crash pixel fire, and that it only happens once (pixel name to filter for is m.debug.crash.daily)
  4. Follow steps 2 and 3 again but check that no second crash pixel is sent

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from Bunn December 9, 2024 20:24
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Initially, I saw the following log entry:

Pixel fired m.d.crash ["appVersion": "7.148.0.3"]

Then, I tried it again and saw this:

Pixel fired m.d.crash ["type": "6", "signal": "5", "code": "1", "appVersion": "7.148.0.3"]

After that, it correctly stopped sending anything, and I can no longer reproduce the issue. I suspect I might have terminated the debugger before it could mark the event as sent or something similar. I don't think it's a cause for alarm, but I wanted to share this in case you have any insights.

@Bunn
Copy link
Contributor

Bunn commented Dec 9, 2024

@samsymons as discussed on MM, I pushed ca0f25c to update the pixel name, gave a second try and I see the pixel being correctly fired only once
Pixel fired m.d.crash.daily ["appVersion": "7.148.0.3"]

Feel free to merge if it looks good to you.

@samsymons samsymons merged commit a78a34f into main Dec 10, 2024
13 checks passed
@samsymons samsymons deleted the sam/crash-daily-pixel branch December 10, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants