Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily crash pixel #3702

Merged
merged 2 commits into from
Dec 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions DuckDuckGo/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,16 @@ import os.log
crashCollection.startAttachingCrashLogMessages { pixelParameters, payloads, sendReport in
pixelParameters.forEach { params in
Pixel.fire(pixel: .dbCrashDetected, withAdditionalParameters: params, includedParameters: [])

// Each crash comes with an `appVersion` parameter representing the version that the crash occurred on.
// This is to disambiguate the situation where a crash occurs, but isn't sent until the next update.
// If for some reason the parameter can't be found, fall back to the current version.
if let crashAppVersion = params[PixelParameters.appVersion] {
let dailyParameters = [PixelParameters.appVersion: crashAppVersion]
DailyPixel.fireDaily(.dbCrashDetected, withAdditionalParameters: dailyParameters)
} else {
DailyPixel.fireDaily(.dbCrashDetected)
}
}

// Async dispatch because rootViewController may otherwise be nil here
Expand Down
Loading