Skip to content

Freemium PIR: Rename all PIR references to DBP #12537

Freemium PIR: Rename all PIR references to DBP

Freemium PIR: Rename all PIR references to DBP #12537

Triggered via pull request September 11, 2024 11:10
Status Failure
Total duration 12m 4s
Billable time 30m
Artifacts

pr.yml

on: pull_request
Matrix: Test
SwiftLint
43s
SwiftLint
Test Shell Scripts
17s
Test Shell Scripts
Make Release Build
7m 40s
Make Release Build
Verify autoconsent bundle
0s
Verify autoconsent bundle
ShellCheck
8s
ShellCheck
Private API Report  /  Update PR comment
2s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

6 errors, 32 warnings, and 1 notice
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DataBroker.swift#L88
Lines should not have trailing whitespace (trailing_whitespace)
SwiftLint: DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift#L278
TODOs should be resolved (Remove this) (todo)
SwiftLint: DuckDuckGo/Freemium/DBP/FreemiumDBPPresenter.swift#L41
TODOs should be resolved (- Onboard (i.e Ts and Cs)) (todo)
SwiftLint: DuckDuckGo/Freemium/DBP/FreemiumDBPPresenter.swift#L51
TODOs should be resolved (- Show onboarding if we decide...) (todo)
SwiftLint: DuckDuckGo/Freemium/DBP/FreemiumDBPFeature.swift#L47
TODOs should be resolved (- Also check experiment cohort...) (todo)
SwiftLint: UnitTests/Freemium/DBP/FreemiumDBPPresenterTests.swift#L51
Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel