Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authe…

…ntication

* sam/logins-filtering-and-sorting:
  Avoid the default empty state appearing at unexpected times.

DuckDuckGo/SecureVault/Model/PasswordManagementItemListModel.swift

@@ -359,6 +359,16 @@ final class PasswordManagementItemListModel: ObservableObject {
             selected(item: nil)
         }
     }
+
+    func clear() {
+        update(items: [])
+        filter = ""
+        clearSelection()
+
+        // Setting items to an empty array will typically show the No Data empty state, but this call is used when
+        // the popover is closed so instead there should be no empty state.
+        emptyState = .none
+    }
 
     func clearSelection() {
         selected = nil

DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift

@@ -266,9 +266,7 @@ final class PasswordManagementViewController: NSViewController {
     }
 
     func clear() {
-        self.listModel?.update(items: [])
-        self.listModel?.filter = ""
-        self.listModel?.clearSelection()
+        self.listModel?.clear()
         self.itemModel?.clearSecureVaultModel()
     }