fix WebView value validation popover crash when WebView not in hierarchy #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
requested review from
a team and
alessandroboron
and removed request for
a team
mallexxx
force-pushed
the
alex/fix-webview-validation-popover-crash
branch
2 times, most recently
from
748a8a0 to
b433781
Compare
samsymons
approved these changes
Jan 24, 2024
samsymons
added a commit
that referenced
this pull request
Jan 25, 2024
# By Alexey Martemyanov (11) and others # Via Dominik Kapusta (3) and others * main: (56 commits) Adds info about whether the login items are actually running (#2122) Remove connection status awaiter. (#2121) Launch VPN Location screen from status view (#2077) Display different copy in alerts when a flag is enabled in a newer version (#2114) Remove delayed webView attaching to main window (#2116) Always start onboarding from the beginning when shown (#2117) Update spacing between UI components in settings (#2109) Show history menu on cmd+y shortcut (#2112) Bump version to 1.72.0 (112) Update embedded files fix WebView value validation popover crash when WebView not in hierarchy (#2108) Fix agent startup (#2107) Support brand UA (#2085) fix Safari favicons import (#2106) Add page attributes to print settings (#2104) Bump version to 1.72.0 (111) Alex/disable onboarding existing users (#2105) Bump version to 1.71.2 (110) Fixes a multithreading issue in `NetworkConnectionTester` (BSK) (#2102) Avoid sending latency immediately after the monitor starts (#2103) ... # Conflicts: # Configuration/BuildNumber.xcconfig # DuckDuckGo/VPNFeedbackForm/VPNMetadataCollector.swift # UnitTests/VPNFeedbackForm/VPNFeedbackFormViewModelTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206407295280737/f
Description:
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation