Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection status awaiter. #2121

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jan 25, 2024

Task/Issue URL: https://app.asana.com/0/0/1206443966711576/f

iOS PR: duckduckgo/iOS#2387
BSK PR: duckduckgo/BrowserServicesKit#635

Description

Removes ConnectionStatusAwaiter which was causing trouble connecting in macOS.

Testing

  1. Connect and disconnect a few times.
  2. Change locations connect and disconnect (be aware there's an unrelated issue that seems to make the connection fail right after changing location). Try to pick distant locations.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 25, 2024
Task/Issue URL: https://app.asana.com/0/0/1206443966711576/f

macOS PR: duckduckgo/macos-browser#2121
iOS PR: duckduckgo/iOS#2387

## Description

Removes `ConnectionStatusAwaiter` which was causing trouble connecting in macOS.
@diegoreymendez diegoreymendez merged commit 695b9bf into main Jan 25, 2024
14 checks passed
@diegoreymendez diegoreymendez deleted the diego/remove-connection-status-awaiter branch January 25, 2024 16:48
diegoreymendez added a commit to duckduckgo/iOS that referenced this pull request Jan 25, 2024
Task/Issue URL: https://app.asana.com/0/0/1206443966711576/f

macOS PR: duckduckgo/macos-browser#2121
BSK PR: duckduckgo/BrowserServicesKit#635

## Description

Updates BSK to the latest version, with no changes for iOS.
samsymons added a commit that referenced this pull request Jan 25, 2024
# By Alexey Martemyanov (11) and others
# Via Dominik Kapusta (3) and others
* main: (56 commits)
  Adds info about whether the login items are actually running (#2122)
  Remove connection status awaiter. (#2121)
  Launch VPN Location screen from status view  (#2077)
  Display different copy in alerts when a flag is enabled in a newer version (#2114)
  Remove delayed webView attaching to main window (#2116)
  Always start onboarding from the beginning when shown (#2117)
  Update spacing between UI components in settings (#2109)
  Show history menu on cmd+y shortcut (#2112)
  Bump version to 1.72.0 (112)
  Update embedded files
  fix WebView value validation popover crash when WebView not in hierarchy (#2108)
  Fix agent startup (#2107)
  Support brand UA (#2085)
  fix Safari favicons import (#2106)
  Add page attributes to print settings (#2104)
  Bump version to 1.72.0 (111)
  Alex/disable onboarding existing users (#2105)
  Bump version to 1.71.2 (110)
  Fixes a multithreading issue in `NetworkConnectionTester` (BSK) (#2102)
  Avoid sending latency immediately after the monitor starts (#2103)
  ...

# Conflicts:
#	Configuration/BuildNumber.xcconfig
#	DuckDuckGo/VPNFeedbackForm/VPNMetadataCollector.swift
#	UnitTests/VPNFeedbackForm/VPNFeedbackFormViewModelTests.swift
samsymons added a commit that referenced this pull request Jan 30, 2024
* main:
  Restore VPN pixels in main browser (#2129)
  Bump BSK to 103.0.2 (#2126)
  Fix `site:` queries escaping with iOS 17 SDK (#640) (#2130)
  Add January 2024 brokers (part 2) (#2125)
  lastSentDate + web breakage report improvements (#2041)
  Remove VPN metadata admin check (#2127)
  Add Spokeo mirror sites (#2086)
  appcastManager: Retain release notes for all versions (#2123)
  Don't report CancellationError from BookmarksFaviconsFetcher (#2120)
  Sabrina/revert cards experiment (#2119)
  Bump version to 1.72.0 (113)
  Update embedded files
  Release Branch: VPN fixes (#2113)
  Adds info about whether the login items are actually running (#2122)
  Remove connection status awaiter. (#2121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants