-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove connection status awaiter. #2121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 25, 2024
Task/Issue URL: https://app.asana.com/0/0/1206443966711576/f macOS PR: duckduckgo/macos-browser#2121 iOS PR: duckduckgo/iOS#2387 ## Description Removes `ConnectionStatusAwaiter` which was causing trouble connecting in macOS.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jan 25, 2024
Task/Issue URL: https://app.asana.com/0/0/1206443966711576/f macOS PR: duckduckgo/macos-browser#2121 BSK PR: duckduckgo/BrowserServicesKit#635 ## Description Updates BSK to the latest version, with no changes for iOS.
samsymons
added a commit
that referenced
this pull request
Jan 25, 2024
# By Alexey Martemyanov (11) and others # Via Dominik Kapusta (3) and others * main: (56 commits) Adds info about whether the login items are actually running (#2122) Remove connection status awaiter. (#2121) Launch VPN Location screen from status view (#2077) Display different copy in alerts when a flag is enabled in a newer version (#2114) Remove delayed webView attaching to main window (#2116) Always start onboarding from the beginning when shown (#2117) Update spacing between UI components in settings (#2109) Show history menu on cmd+y shortcut (#2112) Bump version to 1.72.0 (112) Update embedded files fix WebView value validation popover crash when WebView not in hierarchy (#2108) Fix agent startup (#2107) Support brand UA (#2085) fix Safari favicons import (#2106) Add page attributes to print settings (#2104) Bump version to 1.72.0 (111) Alex/disable onboarding existing users (#2105) Bump version to 1.71.2 (110) Fixes a multithreading issue in `NetworkConnectionTester` (BSK) (#2102) Avoid sending latency immediately after the monitor starts (#2103) ... # Conflicts: # Configuration/BuildNumber.xcconfig # DuckDuckGo/VPNFeedbackForm/VPNMetadataCollector.swift # UnitTests/VPNFeedbackForm/VPNFeedbackFormViewModelTests.swift
samsymons
added a commit
that referenced
this pull request
Jan 30, 2024
* main: Restore VPN pixels in main browser (#2129) Bump BSK to 103.0.2 (#2126) Fix `site:` queries escaping with iOS 17 SDK (#640) (#2130) Add January 2024 brokers (part 2) (#2125) lastSentDate + web breakage report improvements (#2041) Remove VPN metadata admin check (#2127) Add Spokeo mirror sites (#2086) appcastManager: Retain release notes for all versions (#2123) Don't report CancellationError from BookmarksFaviconsFetcher (#2120) Sabrina/revert cards experiment (#2119) Bump version to 1.72.0 (113) Update embedded files Release Branch: VPN fixes (#2113) Adds info about whether the login items are actually running (#2122) Remove connection status awaiter. (#2121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206443966711576/f
iOS PR: duckduckgo/iOS#2387
BSK PR: duckduckgo/BrowserServicesKit#635
Description
Removes
ConnectionStatusAwaiter
which was causing trouble connecting in macOS.Testing
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation