Sabrina/revert cards experiment #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
commented
Jan 25, 2024
| } | ||
|
|
||
| // Often used |
There was a problem hiding this comment.
I thought it was worth leaving those here since they will probably often be used although atm they will not be called
SabrinaTardio
commented
Jan 25, 2024
| @@ -81,156 +81,159 @@ class PixelExperimentTests: XCTestCase { | |||
| PixelExperiment.fireEnrollmentPixel() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Tests will not be working but I thought that we might want to keep the tests since we keep the pixels as common wanted pixels for experiments.
This could be much nicer when we have remote configurable pixels………..
brindy
approved these changes
Jan 26, 2024
samsymons
added a commit
that referenced
this pull request
Jan 30, 2024
* main: Restore VPN pixels in main browser (#2129) Bump BSK to 103.0.2 (#2126) Fix `site:` queries escaping with iOS 17 SDK (#640) (#2130) Add January 2024 brokers (part 2) (#2125) lastSentDate + web breakage report improvements (#2041) Remove VPN metadata admin check (#2127) Add Spokeo mirror sites (#2086) appcastManager: Retain release notes for all versions (#2123) Don't report CancellationError from BookmarksFaviconsFetcher (#2120) Sabrina/revert cards experiment (#2119) Bump version to 1.72.0 (113) Update embedded files Release Branch: VPN fixes (#2113) Adds info about whether the login items are actually running (#2122) Remove connection status awaiter. (#2121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204186595873227/1206438236962578/f
Description: Will revert the remove new tab cards experiment.
Steps to test this PR:
<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGElabel (particularly if it's a draft)If it's pending Product Review/PFR, please add the
Pending Product Reviewlabel.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation