Redirect from purchase page to macOS native purchase flow #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miasma13
force-pushed
the
michal/redirect-to-purchase
branch
from
1c6aee2 to
5acb602
Compare
samsymons
approved these changes
Apr 3, 2024
samsymons
added a commit
that referenced
this pull request
Apr 8, 2024
* main: (338 commits) Fixes the VPN restarting logic on update (#2545) fix download save panel disappearing on navigation (#2549) Add CI support for handling installation attribution (#2502) Bump version to 1.82.0 (152) Pixel changed in subscription (#2541) add LSHandlerRank for .duckload document type (#2537) Fix usertext comment to ensure it matches localizable string (#2546) Update Neighbor Report (#2542) DBP: Compare by url and not name (#2544) DBP: Compare by url and not name (#2544) Adds a series of UI tests for Bookmarks Bar visibility Improve Handling of noData Import Errors (#2494) Bump version to 1.82.0 (151) Use the default action button style for VPN onboarding (#2529) Redirect from purchase page to macOS native purchase flow (#2538) Closing empty tabs after download (#2510) Add Web UI loading state pixels (#2531) fix localization warnings (#2288) Select URL in address bar when editing and use cmd+L (#2536) Add attemptId to Captcha /result endpoint (#2530) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206989054564349/f
Description:
Redirect from purchase page to macOS native purchase flow
Steps to test this PR:
1.Navigation should be redirected to the subscription purchase page
Note: Try navigating via different means (e.g. type in the URL, open a link, bookmark etc.):
Ensure feature flag is disabled and disable internal user state.
Predefine/mock
SubscriptionPurchaseEnvironment.current == .appStoreandSubscriptionPurchaseEnvironment.canPurchase == falseto simulate App Store build with no available productsInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation