Use the default action button style for VPN onboarding #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
approved these changes
Apr 3, 2024
| @@ -95,7 +66,7 @@ struct PromptActionView: View { | |||
| .multilineText() | |||
|
|
|||
| Button(model.actionTitle, action: model.action) | |||
| .applyStepButtonAttributes(colorScheme: colorScheme) | |||
| .keyboardShortcut(.defaultAction) | |||
There was a problem hiding this comment.
Simplicity at its finest.
samsymons
added a commit
that referenced
this pull request
Apr 5, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206958823796186/f Tech Design URL: CC: Description: This PR changes the onboarding button style to the default action style, to fix UX problems where the button doesn't appear clickable enough.
samsymons
added a commit
that referenced
this pull request
Apr 8, 2024
* main: (338 commits) Fixes the VPN restarting logic on update (#2545) fix download save panel disappearing on navigation (#2549) Add CI support for handling installation attribution (#2502) Bump version to 1.82.0 (152) Pixel changed in subscription (#2541) add LSHandlerRank for .duckload document type (#2537) Fix usertext comment to ensure it matches localizable string (#2546) Update Neighbor Report (#2542) DBP: Compare by url and not name (#2544) DBP: Compare by url and not name (#2544) Adds a series of UI tests for Bookmarks Bar visibility Improve Handling of noData Import Errors (#2494) Bump version to 1.82.0 (151) Use the default action button style for VPN onboarding (#2529) Redirect from purchase page to macOS native purchase flow (#2538) Closing empty tabs after download (#2510) Add Web UI loading state pixels (#2531) fix localization warnings (#2288) Select URL in address bar when editing and use cmd+L (#2536) Add attemptId to Captcha /result endpoint (#2530) ...
samsymons
added a commit
that referenced
this pull request
Apr 8, 2024
* main: (22 commits) Removes last instance of NETWORK_PROTECTION flag (#2573) Bye bye NETWORK_PROTECTION (#2509) QWD: Enable Hide/Show for Autofill Credit Card Number and CVV (#2539) Removed the VPN waitlist beta pixels (#2555) VPN: Cleanup authorize call (#2565) Revert "VPN: Cleanup authorize call (#2553)" VPN: Cleanup authorize call (#2553) Improves underlying error pixel information (#2543) Fixes the VPN restarting logic on update (#2545) fix download save panel disappearing on navigation (#2549) Add CI support for handling installation attribution (#2502) Fix usertext comment to ensure it matches localizable string (#2546) Update Neighbor Report (#2542) DBP: Compare by url and not name (#2544) Adds a series of UI tests for Bookmarks Bar visibility Improve Handling of noData Import Errors (#2494) Use the default action button style for VPN onboarding (#2529) Closing empty tabs after download (#2510) Add Web UI loading state pixels (#2531) fix localization warnings (#2288) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206958823796186/f
Tech Design URL:
CC:
Description:
This PR changes the onboarding button style to the default action style, to fix UX problems where the button doesn't appear clickable enough.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation