Bye bye NETWORK_PROTECTION #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
diegoreymendez
added
DO NOT MERGE
and removed
bot: not in app board
diegoreymendez
commented
Mar 27, 2024
| @@ -81,7 +78,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate, FileDownloadManagerDel | |||
| let bookmarksManager = LocalBookmarkManager.shared | |||
| var privacyDashboardWindow: NSWindow? | |||
|
|
|||
| #if NETWORK_PROTECTION && SUBSCRIPTION | |||
There was a problem hiding this comment.
NETWORK_PROTECTION && OTHER_FLAG becomes always OTHER_FLAG
diegoreymendez
commented
Mar 27, 2024
| @@ -582,8 +573,6 @@ func updateSubscriptionStatus() { | |||
| #endif | |||
| } | |||
|
|
|||
| #if NETWORK_PROTECTION || DBP | |||
There was a problem hiding this comment.
NETWORK_PROTECTION || OTHER_FLAG becomes always true and is hence removed
diegoreymendez
commented
Mar 27, 2024
| dataBrokerProtectionUserDefaults: .dbp | ||
| ) | ||
| #else | ||
| return HomePageRemoteMessaging() | ||
| #endif |
There was a problem hiding this comment.
The bottom 2 conditions go away because NETWORK_PROTECTION is always true, so we stick to only the top two conditions.
graeme
approved these changes
Apr 8, 2024
samsymons
added a commit
that referenced
this pull request
Apr 8, 2024
* main: (22 commits) Removes last instance of NETWORK_PROTECTION flag (#2573) Bye bye NETWORK_PROTECTION (#2509) QWD: Enable Hide/Show for Autofill Credit Card Number and CVV (#2539) Removed the VPN waitlist beta pixels (#2555) VPN: Cleanup authorize call (#2565) Revert "VPN: Cleanup authorize call (#2553)" VPN: Cleanup authorize call (#2553) Improves underlying error pixel information (#2543) Fixes the VPN restarting logic on update (#2545) fix download save panel disappearing on navigation (#2549) Add CI support for handling installation attribution (#2502) Fix usertext comment to ensure it matches localizable string (#2546) Update Neighbor Report (#2542) DBP: Compare by url and not name (#2544) Adds a series of UI tests for Bookmarks Bar visibility Improve Handling of noData Import Errors (#2494) Use the default action button style for VPN onboarding (#2529) Closing empty tabs after download (#2510) Add Web UI loading state pixels (#2531) fix localization warnings (#2288) ...
samsymons
added a commit
that referenced
this pull request
Apr 8, 2024
…flagger # By Diego Rey Mendez (7) and others # Via GitHub * main: Automatically close VPN popover when the app goes into the background (#2562) Fix last known VPN crash and missing IPC registration (#2579) Create a new window when making a feedback form if necessary (#2563) Improve VPN uninstallation reliability (#2560) Removes last instance of NETWORK_PROTECTION flag (#2573) Bye bye NETWORK_PROTECTION (#2509) QWD: Enable Hide/Show for Autofill Credit Card Number and CVV (#2539) Removed the VPN waitlist beta pixels (#2555) VPN: Cleanup authorize call (#2565) Revert "VPN: Cleanup authorize call (#2553)" VPN: Cleanup authorize call (#2553) Improves underlying error pixel information (#2543) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206935409526736/f
Description:
Removes the
NETWORK_PROTECTIONfeature flag.Testing:
Test that the full VPN experience works.
Please, take your time to review the whole set of changes. Tick each viewed file and move through all of them. Even if it takes long that's ok.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation