Automatically close VPN popover when the app goes into the background #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users occasionally report confusion about the VPN popover being greyed out, even though it’s active. This is because the popover stays open when the app loses focus, so this commit changes it to dismiss when the app loses focus. However, we want to keep the popover open if the user is onboarding, because otherwise the popover will vanish whenever they get prompted to do something.
diegoreymendez
approved these changes
Apr 8, 2024
samsymons
deleted the
sam/automatically-close-vpn-popover-when-app-is-backgrounded
branch
samsymons
added a commit
that referenced
this pull request
Apr 8, 2024
…flagger # By Diego Rey Mendez (7) and others # Via GitHub * main: Automatically close VPN popover when the app goes into the background (#2562) Fix last known VPN crash and missing IPC registration (#2579) Create a new window when making a feedback form if necessary (#2563) Improve VPN uninstallation reliability (#2560) Removes last instance of NETWORK_PROTECTION flag (#2573) Bye bye NETWORK_PROTECTION (#2509) QWD: Enable Hide/Show for Autofill Credit Card Number and CVV (#2539) Removed the VPN waitlist beta pixels (#2555) VPN: Cleanup authorize call (#2565) Revert "VPN: Cleanup authorize call (#2553)" VPN: Cleanup authorize call (#2553) Improves underlying error pixel information (#2543) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users occasionally report confusion about the VPN popover being greyed out, even though it’s active. This is because the popover stays open when the app loses focus, so this commit changes it to dismiss when the app loses focus.
However, we want to keep the popover open if the user is onboarding, because otherwise the popover will vanish whenever they get prompted to do something.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206164244676889/f
Tech Design URL:
CC:
Description:
This PR updates the VPN popover to dismiss any time the app enters the background, in reaction to users occasionally being confused about why the UI appeared greyed out.
We only do this if the user is already onboarded, as otherwise the popover keeps dismissing any time they go to complete some onboarding step.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation