Duck Player - Improved Settings + Ship Review feedback #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 The Asana task linked in the PR description is not added to macOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
Bunn
commented
Jul 16, 2024
| @@ -46,7 +46,7 @@ struct DuckPlayerPreferencesUserDefaultsPersistor: DuckPlayerPreferencesPersisto | |||
| @UserDefaultsWrapper(key: .duckPlayerAutoplay, defaultValue: true) | |||
| var duckPlayerAutoplay: Bool | |||
|
|
|||
| @UserDefaultsWrapper(key: .duckPlayerOpenInNewTab, defaultValue: false) | |||
| @UserDefaultsWrapper(key: .duckPlayerOpenInNewTab, defaultValue: true) | |||
There was a problem hiding this comment.
Important to test the case where the feature flag is unavailable (and user is not internal) that the videos will not play on a new tab
# Conflicts: # DuckDuckGo/Localizable.xcstrings
|
Bunn
removed
the
bot: not in app board
jotaemepereira
pushed a commit
that referenced
this pull request
Aug 3, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1207821426171629/f **Description**: Ship review feedback changes
samsymons
added a commit
that referenced
this pull request
Aug 4, 2024
# By Dax the Duck (8) and others # Via GitHub (5) and Alexey Martemyanov (2) * main: (44 commits) Add RMF `messageShown` attribute (#3062) Update autoconsent to v10.13.0 (#3063) [DuckPlayer] 1. Move Extension to BSK and add Init Updates (#3055) Bump version to 1.100.0 (238) Bump version to 1.100.0 (237) Improve sorting logic and related test (#3064) VPN Waitlist and Debug Menu code cleanup. (#3059) restore CrashLogMessageExtractor (#3011) xattr command removed from the restarting script to avoid the macOS notification (#3057) Duck Player - Improved Settings + Ship Review feedback (#2981) Fix flaky TabContentTests (#3060) PIR Database Migrations: Remove Temporary Internal Time-Based Feature Flag (#3054) Bump version to 1.100.0 (236) Remove unused messaging system (#3047) Automatically add Asana task to macOS App Board (#3053) Disable password generation for burner windows (#3024) PIR: Improve sorting logic and related test (#3049) Remove @mainactor from test case class definitions (#3048) Fix autoplay FF behavior (#3032) Fix ghost InfoPlist.xcstrings (#3044) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207821426171629/f
Tech Design URL:
CC:
Description:
Ship review feedback changes
Steps to test this PR: