Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xattr command removed from the restarting script to avoid the macOS notification #3057

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1201048563534612/1207945245157372/f

Description:
xattr command removed from the restarting script to avoid the macOS notification.

Steps to test this PR:

  1. Change the build number and version number to lower numbers (Version.xcconfig, BuildNumber.xcconfig)
  2. Change the implementation of configureUpdater() in UpdateController.swift
    private func configureUpdater() {
        // The default configuration of Sparkle updates is in Info.plist
        updater = SPUStandardUpdaterController(updaterDelegate: self, userDriverDelegate: self)
        shouldShowManualUpdateDialog = false

        if updater.updater.automaticallyDownloadsUpdates != areAutomaticUpdatesEnabled {
            updater.updater.automaticallyDownloadsUpdates = areAutomaticUpdatesEnabled
        }

#if DEBUG
//        updater.updater.automaticallyChecksForUpdates = false
//        updater.updater.automaticallyDownloadsUpdates = false
//        updater.updater.updateCheckInterval = 0
#endif

        checkForUpdateInBackground()
    }
  1. Run the app
  2. Wait until the app loads a new update
  3. Use "Restart to Update" button (either in settings, right menu or Release Notes page)
  4. Make sure the app is restarted and the new app session has higher version and build number (DuckDuckGo -> About DuckDuckGo)

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@tomasstrba tomasstrba changed the base branch from main to release/1.100.0 July 31, 2024 18:17
@tomasstrba tomasstrba changed the base branch from release/1.100.0 to main July 31, 2024 18:18
@afterxleep afterxleep self-requested a review August 1, 2024 09:36
@tomasstrba
Copy link
Contributor Author

Thank you, @afterxleep! 🙏

@tomasstrba tomasstrba merged commit 8f59f09 into main Aug 1, 2024
29 checks passed
@tomasstrba tomasstrba deleted the tom/prevented-dialog branch August 1, 2024 20:04
samsymons added a commit that referenced this pull request Aug 4, 2024
# By Dax the Duck (8) and others
# Via GitHub (5) and Alexey Martemyanov (2)
* main: (44 commits)
  Add RMF `messageShown` attribute (#3062)
  Update autoconsent to v10.13.0 (#3063)
  [DuckPlayer] 1. Move Extension to BSK and add Init Updates (#3055)
  Bump version to 1.100.0 (238)
  Bump version to 1.100.0 (237)
  Improve sorting logic and related test (#3064)
  VPN Waitlist and Debug Menu code cleanup. (#3059)
  restore CrashLogMessageExtractor (#3011)
  xattr command removed from the restarting script to avoid the macOS notification (#3057)
  Duck Player - Improved Settings + Ship Review feedback (#2981)
  Fix flaky TabContentTests (#3060)
  PIR Database Migrations: Remove Temporary Internal Time-Based Feature Flag (#3054)
  Bump version to 1.100.0 (236)
  Remove unused messaging system (#3047)
  Automatically add Asana task to macOS App Board (#3053)
  Disable password generation for burner windows (#3024)
  PIR: Improve sorting logic and related test (#3049)
  Remove @mainactor from test case class definitions (#3048)
  Fix autoplay FF behavior (#3032)
  Fix ghost InfoPlist.xcstrings (#3044)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
tomasstrba added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants