Update Attribution logic and debug logs #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bwaresiak
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 7, 2024
#1059) <!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1201037661562251/1206957650592842/f iOS PR: duckduckgo/iOS#3548 macOS PR: duckduckgo/macos-browser#3514 What kind of version bump will this require?: Patch **Description**: Fix the possible state issue, when it was updated more than once in some cases. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. Put a break when firing `adAttributionLogicUnexpectedStateOnRulesCompiled` 2. Search for something, then cmd+click to open multiple background tabs with that AD. 3. Expected: no error is fired. Smoke test regular attribution flows. <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
samsymons
added a commit
that referenced
this pull request
Nov 8, 2024
# By Fernando Bunn (2) and others # Via GitHub * main: Update Attribution logic and debug logs (#3514) Update send feedback icon (#3524) PIR E2E tests (#3512) Respect new tab order preference (#3525) Fix passwords empty screen lock icon in dark mode (#3436) Bump version to 1.113.0 (301) Translations for AI Chat copy changes (#3522) Restore calling run-publish-dmg-release on tag_release.yml failure (#3520) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/856498667320406/1206957650592842/f
Tech Design URL:
CC:
Description:
Update the logic to reduce number of debug signals related to valid use cases.
Steps to test this PR:
See the BSK PR for details.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation