Restore calling run-publish-dmg-release on tag_release.yml failure #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshann
approved these changes
Nov 6, 2024
samsymons
added a commit
that referenced
this pull request
Nov 8, 2024
# By Fernando Bunn (2) and others # Via GitHub * main: Update Attribution logic and debug logs (#3514) Update send feedback icon (#3524) PIR E2E tests (#3512) Respect new tab order preference (#3525) Fix passwords empty screen lock icon in dark mode (#3436) Bump version to 1.113.0 (301) Translations for AI Chat copy changes (#3522) Restore calling run-publish-dmg-release on tag_release.yml failure (#3520) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203301625297703/1208705384164248/f
Description:
run-publish-dmg-release task needs to be created directly from the GHA workflow because we want to
address the actual workflow failure (i.e. when the dependent workflow can't run). This is impossible
to check from the fastlane action.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation