VPN auth token logic update #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
diegoreymendez
pushed a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 18, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1207603085593419/1208194658564979/f iOS PR: duckduckgo/iOS#3585 macOS PR: duckduckgo/macos-browser#3562 What kind of version bump will this require?: Patch **Description**: This PR updates the logic used when the auth token startup check fails.
diegoreymendez
approved these changes
Nov 18, 2024
samsymons
added a commit
that referenced
this pull request
Nov 18, 2024
* main: Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 Update embedded files Bump plugin-ddg_apple_automation (#3564) Migrate release flow components to FastLane (#3563) VPN auth token logic update (#3562)
mgurgel
pushed a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 18, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1207603085593419/1208194658564979/f iOS PR: duckduckgo/iOS#3585 macOS PR: duckduckgo/macos-browser#3562 What kind of version bump will this require?: Patch **Description**: This PR updates the logic used when the auth token startup check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208194658564979/f
Tech Design URL:
CC:
Description:
This PR updates BSK with some auth token logic updates that were written for iOS.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation