Migrate release flow components to FastLane #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
Nov 18, 2024
samsymons
added a commit
that referenced
this pull request
Nov 18, 2024
* main: Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 Update embedded files Bump plugin-ddg_apple_automation (#3564) Migrate release flow components to FastLane (#3563) VPN auth token logic update (#3562)
2 tasks
kshann
added a commit
that referenced
this pull request
Nov 25, 2024
Task/Issue URL: https://app.asana.com/0/1205419239275955/1208658415307255/f Tech Design URL: CC: **Description**: - Update hotfix release flow to use new Fastlane actions - `build_hotfix_release.yml` executes the same action we use in `start_new_release`. I didn't explicitly test this flow here but. I followed suit with what has been done in [publish_dmg_release.yml](https://github.com/duckduckgo/macos-browser/blob/15a5208e8b45959e26a28951cf3f3223cce8fd3f/.github/workflows/publish_dmg_release.yml#L250) and the action was tested in #3563 **Optional E2E tests**: - [ ] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. **Steps to test this PR**: 1. See successful [run](https://github.com/duckduckgo/macos-browser/actions/runs/11952774788) 2. [Second test](https://github.com/duckduckgo/macos-browser/actions/runs/11988103007) after PR feedback on automation PR <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Dominik Kapusta <dkapusta@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208137627434479
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
2.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation