Remove GPC header if it exists when not needed #366
Conversation
There was a problem hiding this comment.
Nice Brad! 👍 Just few details to polish since algo has to be as optimized as possible.
Please, could you also merge with develop? In the current version, there is an issue with user scripts and I got 'GPC signal not detected' in https://globalprivacycontrol.org/. It may be related
Looks good on my end 👍 |
There was a problem hiding this comment.
@SlayterDev, in the current implementation GPCRequestFactory may end up with the outdated configuration.
|
I'm afraid this went the other direction I suggested. Now there are cases when privacy config data are out of sync. Can privacyConfig of PrivacyConfigurationManager be refactored? The problem in initial implementation was it was a computed property triggering a computation on every access. Even worse is it accesses fetchedConfigData under the lock with blocks concurrent loading. In ideal case, |
|
Hey @SlayterDev, please, can I help with this? I didn't want to block you. Please, feel free to merge with the version you are comfortable and we can resolve the optimisation as a follow-up task. |
|
Sounds good @tomasstrba. I meant to get with @bwaresiak on this but many things have come up since then. |
# By Alexey Martemyanov (20) and others # Via Tomas Strba (2) and others * develop: (63 commits) Tweaks of suggestions and autocomplete (#403) Bump privacy dashboard to latest version (#409) Point to the latest BrowserServicesKit branch. (#414) Move embedded TDS from BSK to platform repo (#412) Image of shield with dot replaced (#410) Expand Fireproofing to include Local Storage and IndexedDB (#408) Version 0.18.5 support privacy config for clickToLoad (#407) Automatically select available login (#405) initial FB Click to Load (WIP) (#329) onboarding updates (#398) Version 0.18.4 Configuration of Sparkle - Setting SUAllowsAutomaticUpdates to NO (#404) Hide downloads button if the popover is opened/closed manually (#397) Textfield of the homepage is empty and unfocused right after switching to the homepage (#400) Remove navigatorCredentials (#392) Remove GPC header if it exists when not needed (#366) Version 0.18.3 Fireproofing encrypted storage (#332) Fix Lock Screen UI issues (#399) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Crash Reports/Model/CrashReportSender.swift
Task/Issue URL:
Tech Design URL:
CC:
Description:
Fixes an issue where GPC header wasn't removed when allow listing a site
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM