Remove navigatorCredentials

[jonathanKingston]

Task/Issue URL: https://app.asana.com/0/1163321984198618/1201071474741984/f and https://app.asana.com/0/1200437802575119/1201288740667760/f
Tech Design URL:
CC:

Description:

Removes navigatorCredentials.js and moves it to: duckduckgo/content-scope-scripts#5

• Relies on Navigator credentials move BrowserServicesKit#47

This is a follow up from: #389 (merged)

Steps to test this PR:

1. Open imgur.com and see if it loads
2. In the web inspector ensure navigator.credentials.get() exists

Testing checklist:

• Test with Release configuration

---

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

[jonathanKingston]

@bwaresiak this is ready to land, I just need to update the branch reference once the BrowserServicesKit change has landed.

[tomasstrba]

@jonathanKingston, navigator.credentials seems to be undefined. Am I missing something?

Note: I needed to merge develop into this branch in order to compile successfully. Reference to BSK remained yours. Also, it is a good practice to reference a commit directly. Once you push another commit into the branch Xcode won't recognize it 🤷‍♂️ We spent some time figuring this out :D

[jonathanKingston]

navigator.credentials seems to be undefined. Am I missing something?

Yeah, did you change the submodule in BSK perhaps. I see the code in the other PR: https://github.com/duckduckgo/BrowserServicesKit/pull/47/files (src/features/navigator-interface.js is the new file and it's code should be in the built output build/apple/contentScope.js)

Also, it is a good practice to reference a commit directly. Once you push another commit into the branch Xcode won't recognize it

I'm not sure I follow, by pointing to a feature branch in the PR, if I push to BSK in XCode I can just press update where as with a fixed commit I have to update both PRs. (The intention isn't to keep it as the feature branch at merge)

I needed to merge develop into this branch in order to compile successfully.

I'll rebase :)

[tomasstrba]

LGTM! 👍 Thanks for the rebase!

In my previous comment, I was talking about referencing BSK by its commit instead of a feature branch. Once you push a new commit into the feature branch, it may not be loaded by Xcode

[jonathanKingston]

In my previous comment, I was talking about referencing BSK by its commit instead of a feature branch. Once you push a new commit into the feature branch, it may not be loaded by Xcode

I wonder if not checking the resolved changes in would help here? I repro'd what you meant with XCode and a clean checkout. That way I can force push and your XCode would resolve correctly?

Anyway pointed to the merged BSK now; please note I removed all package and eslint code as we no longer have JS in the codebase (that's not a repo in it's own right) 🥳 . ESLint was failing because it was matching no files.

[jonathanKingston]

This is also failing Bitrise because of the removed npm step... can't win. So if you're able to remove that, that should get it passing.

Update: I added this back in but made the test always pass. We could remove this in a follow up commit.