Hotfix: Rename ATB keys so that the app thinks it's a new install #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Dec 15, 2021
|
|
||
| // These are the original ATB keys that have been replaced in order to resolve retention data issues. | ||
| // These keys should be removed from the database in the future. | ||
| private struct DeprecatedKeys { |
There was a problem hiding this comment.
Not removing these for now just so we can make the simplest possible change and resolve the issue, cleanup can happen later.
samsymons
added a commit
that referenced
this pull request
Dec 17, 2021
# By Alexey Martemyanov (4) and others # Via GitHub (1) and Tomas Strba (1) * develop: mvp onboarding (#377) Update dark mode shield icon asset (#374) Mac Waitlist Lock Screen (#372) drop legacy atb (#376) Version 0.18.0 Hotfix: Rename ATB keys so that the app thinks it's a new install (#375) Version 0.17.8 Point to updated BSK version (#371) Fixing macOS desktop app retention metrics (#370) fix bookmark editing and colors (#364) ATB -> PixelDataStore (#356) Fix deallocation (#369) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1201495686896081/f
Tech Design URL:
CC: @tomasstrba
Description:
This PR renames the ATB keys to trick the browser into thinking that it's a new install, so that users on existing versions don't muddy our retention data.
Important: @tomasstrba I branched off of
mainfor this with the intention of us putting out a release purely with this change, and nothing else ondevelop.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM