ATB -> PixelDataStore #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
reviewed
Nov 29, 2021
bwaresiak
reviewed
Nov 29, 2021
DuckDuckGo/Statistics/PixelDataModel.xcdatamodeld/PixelDataModel.xcdatamodel/contents
Show resolved
Hide resolved
bwaresiak
reviewed
Nov 29, 2021
|
Also included Pixel Event Counter removal in the PR |
bwaresiak
reviewed
Nov 30, 2021
samsymons
added a commit
that referenced
this pull request
Dec 13, 2021
# By Alexey Martemyanov (3) and others # Via GitHub * develop: Point to updated BSK version (#371) Fixing macOS desktop app retention metrics (#370) fix bookmark editing and colors (#364) ATB -> PixelDataStore (#356) Fix deallocation (#369) Initialize user scripts when setting up the WebView (#363) bookmarks management improvements (#362) BSK branch setting changed to exact commit (#360) Tweak the alignment of the home page search bar. (#353) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Dec 17, 2021
# By Alexey Martemyanov (4) and others # Via GitHub (1) and Tomas Strba (1) * develop: mvp onboarding (#377) Update dark mode shield icon asset (#374) Mac Waitlist Lock Screen (#372) drop legacy atb (#376) Version 0.18.0 Hotfix: Rename ATB keys so that the app thinks it's a new install (#375) Version 0.17.8 Point to updated BSK version (#371) Fixing macOS desktop app retention metrics (#370) fix bookmark editing and colors (#364) ATB -> PixelDataStore (#356) Fix deallocation (#369) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199237043630360/1201348978797639
Tech Design URL:
CC: @tomasstrba @brindy
Description:
Moves ATB data storage to PixelDataStore from UserDefaults
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM