Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize user scripts when setting up the WebView #363

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Initialize user scripts when setting up the WebView #363

merged 1 commit into from
Dec 7, 2021

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL:

Tech Design URL:
CC:

Description:
Ensure user scripts are initialized when setting up WebView

Steps to test this PR:

  1. Make sure open in new tab/window works as expected in existing and new tabs.
  2. Same with find in page.

Testing checklist:

  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy self-assigned this Dec 7, 2021
brindy
brindy approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwaresiak bwaresiak merged commit 3898ed2 into develop Dec 7, 2021
@bwaresiak bwaresiak deleted the bartek/fix-user-scripts branch December 7, 2021 13:17
samsymons added a commit that referenced this pull request Dec 13, 2021
@samsymons
Merge branch 'develop' into sam/mac-waitlist-lock-screen
f390b98 
# By Alexey Martemyanov (3) and others
# Via GitHub
* develop:
  Point to updated BSK version (#371)
  Fixing macOS desktop app retention metrics (#370)
  fix bookmark editing and colors (#364)
  ATB -> PixelDataStore (#356)
  Fix deallocation (#369)
  Initialize user scripts when setting up the WebView (#363)
  bookmarks management improvements (#362)
  BSK branch setting changed to exact commit (#360)
  Tweak the alignment of the home page search bar. (#353)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees

@brindy brindy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwaresiak @brindy