bookmarks management improvements #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the URL was longer than the title
brindy
commented
Dec 3, 2021
| @@ -238,6 +238,7 @@ final class AddressBarButtonsViewController: NSViewController { | |||
| } | |||
|
|
|||
| if !bookmarkPopover.isShown { | |||
| bookmarkButton.isHidden = false | |||
There was a problem hiding this comment.
Bug fix to show popover when adding a bookmark
samsymons
reviewed
Dec 5, 2021
Comment on lines
+61
to
+70
| /* | ||
| 1 2 | ||
| c4 _______ c1 | ||
| / \ | ||
| 8 | | 3 | ||
| | | | ||
| 7 | | 4 | ||
| c3 \_______/ c2 | ||
| 6 5 | ||
| */ |
samsymons
reviewed
Dec 5, 2021
|
|
||
| } | ||
|
|
||
| convenience init(roundedRect rect: CGRect, forCorners corners: [Corners], cornerRadius: CGFloat) { |
There was a problem hiding this comment.
Sucks that this isn't an official part of the SDK. Nice work here though 🙂
samsymons
approved these changes
Dec 5, 2021
|
@brindy Sorry for not getting a chance to review this before it was merged, but I'm seeing a couple of bugs with this:
Screen.Recording.2021-12-06.at.10.32.45.AM.mov
Screen.Recording.2021-12-06.at.10.34.43.AM.mov
I can file these as followups somewhere else if you want. |
|
Thanks @bstandaert-ddg ! For 1 can you create a task and assign that to me, please? Feels like it should get fixed. As for the others, can you create sub-tasks under https://app.asana.com/0/1177771139624306/1200857259881361 please? Thanks |
|
Done. |
samsymons
added a commit
that referenced
this pull request
Dec 13, 2021
# By Alexey Martemyanov (3) and others # Via GitHub * develop: Point to updated BSK version (#371) Fixing macOS desktop app retention metrics (#370) fix bookmark editing and colors (#364) ATB -> PixelDataStore (#356) Fix deallocation (#369) Initialize user scripts when setting up the WebView (#363) bookmarks management improvements (#362) BSK branch setting changed to exact commit (#360) Tweak the alignment of the home page search bar. (#353) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1201320333982208
Tech Design URL:
CC:
Description:
Improve hover states and allow multiple selections in the bookmarks management UI.
Fixes bug to re-show popver when adding a bookmark.
Steps to test this PR:
Bookmarks Popover:
Management UI:
Bug fix:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM