Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clickToLoadConfig.json #435

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Update clickToLoadConfig.json #435

merged 2 commits into from
Feb 24, 2022

Conversation

ladamski
Copy link
Collaborator

@ladamski ladamski commented Feb 21, 2022

Task/Issue URL: https://app.asana.com/0/1163321984198618/1201804512156803/f
Tech Design URL:
CC:

Description:
Updating some Click to Load copy based upon discussion in above task.

Steps to test this PR:

  1. Load https://privacy-test-pages.glitch.me/privacy-protections/click-to-load/
  2. Ensure nothing looks broken

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tomasstrba tomasstrba merged commit b0227d1 into develop Feb 24, 2022
@tomasstrba tomasstrba deleted the la/FB-copy branch February 24, 2022 11:42
jonathanKingston pushed a commit that referenced this pull request Feb 25, 2022
Updating Click to Load copy

Author: ladamski@duckduckgo.com <ladamski@duckduckgo.com>
samsymons added a commit that referenced this pull request Feb 25, 2022
# By Sam Macbeth (2) and others
# Via GitHub
* develop:
  Top autofill (#432)
  Option to add new notes or edit existing is disabled (#446)
  Use our own autoconsent fork (#444)
  New Feedback Form (#424)
  Update privacy dashboard (#440)
  Fix crash when background tabs trigger cookie popup (#439)
  Update clickToLoadConfig.json (#435)
  rename weakAssign to assign(to:onWeaklyHeld:) (#442)
  Improve Safari favorite importing (#436)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants