Option to add new notes or edit existing is disabled #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasstrba
changed the title
brindy
reviewed
Feb 24, 2022
| } | ||
| .buttonStyle(StandardButtonStyle()) | ||
| } | ||
| Text("⚠️ Notes are deprecated.") |
There was a problem hiding this comment.
I guess we can skip UserText here, since it's temporary?
There was a problem hiding this comment.
I basically wanted to leave a simple information to users what is happening. I expected something to change during the design review but seems we are moving forward with this and there will be follow-up tasks
brindy
approved these changes
Feb 24, 2022
|
Bitrise was red on one of the checks but I rebuilt it and it's green now 💚 |
|
Awesome, thanks Sam! In the meantime I merged develop which triggered checks again. Once they finish green I will merge :) Also thank you Brindy for a quick review! |
samsymons
added a commit
that referenced
this pull request
Feb 25, 2022
# By Sam Macbeth (2) and others # Via GitHub * develop: Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444) New Feedback Form (#424) Update privacy dashboard (#440) Fix crash when background tabs trigger cookie popup (#439) Update clickToLoadConfig.json (#435) rename weakAssign to assign(to:onWeaklyHeld:) (#442) Improve Safari favorite importing (#436) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 2, 2022
# By Tomas Strba (6) and others # Via GitHub (1) and Tomas Strba (1) * develop: Logins+ authentication (#438) Update privacy dashboard to main (#451) Version 0.19.1 Remove mouse event listeners on browser close (#448) Find in Page Hotfix + refactoring of forced unwrapping (#450) Memory leak fixed (#449) Version 0.19.0 Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444) New Feedback Form (#424) Update privacy dashboard (#440) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/SecureVault/View/PasswordManager.storyboard
samsymons
added a commit
that referenced
this pull request
Mar 4, 2022
* develop: Logins+ authentication (#438) Update privacy dashboard to main (#451) Version 0.19.1 Remove mouse event listeners on browser close (#448) Find in Page Hotfix + refactoring of forced unwrapping (#450) Memory leak fixed (#449) Version 0.19.0 Top autofill (#432) Option to add new notes or edit existing is disabled (#446) Use our own autoconsent fork (#444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201819261413662/f
Tech Design URL: -
Description:
As a first step to deprecate notes, we have decided to disable the ability to add new notes or edit existing notes.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM