Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google spreadsheets login fix #616

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Google spreadsheets login fix #616

merged 2 commits into from
Jun 16, 2022

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1200223097357040/1202412026341243/f
Tech Design URL:
CC:

Description:
Fix of login into Google spreadsheets

Steps to test this PR:

  1. Logout of Google if necessary
  2. Visit https://www.google.co.uk/sheets/about/
  3. Login
  4. Verify spreadsheets work as expected

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@samsymons samsymons self-assigned this Jun 15, 2022
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sheets works well again. The question is: for how long will it keep working this time? 😩

@samsymons samsymons assigned tomasstrba and unassigned samsymons Jun 15, 2022
@tomasstrba tomasstrba merged commit f118f0e into develop Jun 16, 2022
@tomasstrba tomasstrba deleted the tom/google-sheets branch June 16, 2022 11:01
samsymons added a commit that referenced this pull request Jun 18, 2022
* develop:
  Microsoft logo for address bar animation (#618)
  Google spreadsheets login fix (#616)
samsymons added a commit that referenced this pull request Jun 29, 2022
* develop:
  Update sparkle-sandbox.sh README to highlight proper usage
  Replace altool with notarytool in release build script (#623)
  Update embedded data
  Bump version to 0.26.4
  Update homepage history feed after burning (#620)
  Firefox data import improvements (#622)
  Set version to 0.26.3
  Microsoft logo for address bar animation (#618)
  Google spreadsheets login fix (#616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants