Fix of homepage history feed issue after burning #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasstrba
changed the title
tomasstrba
changed the title
samsymons
added a commit
that referenced
this pull request
Jun 29, 2022
* develop: Update sparkle-sandbox.sh README to highlight proper usage Replace altool with notarytool in release build script (#623) Update embedded data Bump version to 0.26.4 Update homepage history feed after burning (#620) Firefox data import improvements (#622) Set version to 0.26.3 Microsoft logo for address bar animation (#618) Google spreadsheets login fix (#616)
samsymons
added a commit
that referenced
this pull request
Jul 4, 2022
# By Dominik Kapusta (5) and others # Via Dominik Kapusta (1) and GitHub (1) * develop: Use updated BSK branch (#627) Version 0.26.5 Embedded files updated Update BSK for iOS app group (#630) Recently Closed Menu Item (#617) Close dashboard when closing tab with cmd + w (#628) chore(deps): bump Autofill to 4.7.0 (#631) Handle legacy crash logs and use proper architecture in symbolicate.js (#621) Detect when Chrome login fails due to keychain prompt denial (#633) Correctly display unprotected sites on dashboard (#624) Update homefavicon (#625) Update sparkle-sandbox.sh README to highlight proper usage Replace altool with notarytool in release build script (#623) Update embedded data Bump version to 0.26.4 Update homepage history feed after burning (#620) Firefox data import improvements (#622) Set version to 0.26.3 # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202472796284065/f
Description:
This PR fixes a privacy issue of homepage history feed. In few cases, the feed was not refreshed after burning and contained burned domains
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM