Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DDG home icon #625

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Update DDG home icon #625

merged 1 commit into from
Jun 29, 2022

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Jun 28, 2022

Task/Issue URL: https://app.asana.com/0/1177771139624306/1202444402883584/f

Description:
Replace DDG favicon
Before
Before

After
After

Steps to test this PR:

  1. Open a new tab and check if the tab icon for DDG looks good
  2. Check if the asset from the asana task is the one being used

@ayoy ayoy self-assigned this Jun 28, 2022
@ayoy ayoy self-requested a review June 28, 2022 18:45
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new icon looks great! 🎉

@Bunn Bunn merged commit 0acdd4e into develop Jun 29, 2022
@Bunn Bunn deleted the bugfix/bunn/homeicon branch June 29, 2022 08:56
samsymons added a commit that referenced this pull request Jul 4, 2022
# By Dominik Kapusta (5) and others
# Via Dominik Kapusta (1) and GitHub (1)
* develop:
  Use updated BSK branch (#627)
  Version 0.26.5
  Embedded files updated
  Update BSK for iOS app group (#630)
  Recently Closed Menu Item (#617)
  Close dashboard when closing tab with cmd + w (#628)
  chore(deps): bump Autofill to 4.7.0 (#631)
  Handle legacy crash logs and use proper architecture in symbolicate.js (#621)
  Detect when Chrome login fails due to keychain prompt denial (#633)
  Correctly display unprotected sites on dashboard (#624)
  Update homefavicon (#625)
  Update sparkle-sandbox.sh README to highlight proper usage
  Replace altool with notarytool in release build script (#623)
  Update embedded data
  Bump version to 0.26.4
  Update homepage history feed after burning (#620)
  Firefox data import improvements (#622)
  Set version to 0.26.3

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
samsymons added a commit that referenced this pull request Jul 8, 2022
# By Fernando Bunn (6) and others
# Via Chris Brind (3) and others
* develop:
  update files and bump release verison
  Check the image rule compilation error correctly (#635)
  Check that the alerting WKWebView is currently selected. (#637)
  Fix issue when unplugging external monitor (#629)
  Select tabs when browser is not focused (#632)
  Revert "Update BSK for iOS app group (#630)" (#634)
  Use updated BSK branch (#627)
  Version 0.26.5
  Embedded files updated
  Update BSK for iOS app group (#630)
  Recently Closed Menu Item (#617)
  Close dashboard when closing tab with cmd + w (#628)
  chore(deps): bump Autofill to 4.7.0 (#631)
  Handle legacy crash logs and use proper architecture in symbolicate.js (#621)
  Detect when Chrome login fails due to keychain prompt denial (#633)
  Correctly display unprotected sites on dashboard (#624)
  Update homefavicon (#625)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants