Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update BSK for iOS app group (#630)" #634

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Jul 4, 2022

Task/Issue URL: https://app.asana.com/0/0/1202546257736894/f

Description:
This reverts commit 4abf93b. (PR: #630)

Steps to test this PR:
Test same steps as the reverted PR steps: #630

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

This reverts commit 4abf93b.

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@tomasstrba tomasstrba self-requested a review July 4, 2022 12:34
@tomasstrba
Copy link
Contributor

I am experiencing issues with signing out from email or generating email address. The issue is present on develop branch too. Planning to investigate it and then continue with the review of this PR if nobody reviews it in the meantime

@tomasstrba tomasstrba self-assigned this Jul 4, 2022
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tomasstrba tomasstrba assigned Bunn and unassigned tomasstrba Jul 4, 2022
Bunn added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 4, 2022
Required:
Task/Issue URL: https://app.asana.com/0/0/1202546257736894/f
iOS PR: duckduckgo/iOS#1224
macOS PR: duckduckgo/macos-browser#634
What kind of version bump will this require?: Major

Description:
Reverts #113
@Bunn Bunn merged commit 6031ddf into develop Jul 4, 2022
@Bunn Bunn deleted the bugfix/bunn/revert-securevault branch July 4, 2022 14:37
samsymons added a commit that referenced this pull request Jul 4, 2022
* develop:
  Revert "Update BSK for iOS app group (#630)" (#634)
samsymons added a commit that referenced this pull request Jul 8, 2022
# By Fernando Bunn (6) and others
# Via Chris Brind (3) and others
* develop:
  update files and bump release verison
  Check the image rule compilation error correctly (#635)
  Check that the alerting WKWebView is currently selected. (#637)
  Fix issue when unplugging external monitor (#629)
  Select tabs when browser is not focused (#632)
  Revert "Update BSK for iOS app group (#630)" (#634)
  Use updated BSK branch (#627)
  Version 0.26.5
  Embedded files updated
  Update BSK for iOS app group (#630)
  Recently Closed Menu Item (#617)
  Close dashboard when closing tab with cmd + w (#628)
  chore(deps): bump Autofill to 4.7.0 (#631)
  Handle legacy crash logs and use proper architecture in symbolicate.js (#621)
  Detect when Chrome login fails due to keychain prompt denial (#633)
  Correctly display unprotected sites on dashboard (#624)
  Update homefavicon (#625)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@ayoy ayoy unassigned Bunn Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants