Prevent inactive tabs from presenting alerts #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Tested on both JSFiddle and privacy test page
working as expected.
LGTM ✅
samsymons
deleted the
sam/prevent-alerts-from-inactive-tabs-from-appearing
branch
samsymons
added a commit
that referenced
this pull request
Jul 8, 2022
# By Fernando Bunn (6) and others # Via Chris Brind (3) and others * develop: update files and bump release verison Check the image rule compilation error correctly (#635) Check that the alerting WKWebView is currently selected. (#637) Fix issue when unplugging external monitor (#629) Select tabs when browser is not focused (#632) Revert "Update BSK for iOS app group (#630)" (#634) Use updated BSK branch (#627) Version 0.26.5 Embedded files updated Update BSK for iOS app group (#630) Recently Closed Menu Item (#617) Close dashboard when closing tab with cmd + w (#628) chore(deps): bump Autofill to 4.7.0 (#631) Handle legacy crash logs and use proper architecture in symbolicate.js (#621) Detect when Chrome login fails due to keychain prompt denial (#633) Correctly display unprotected sites on dashboard (#624) Update homefavicon (#625) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202569779116574/f
Tech Design URL:
CC:
Description:
This PR adds checks to the JavaScript alert presentation callbacks to verify that the webview requesting it is the same one that is visible on the BrowserTabViewController.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM