Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret values not erased #12

Closed
moCello opened this issue Apr 17, 2024 · 0 comments · Fixed by #15
Closed

Secret values not erased #12

moCello opened this issue Apr 17, 2024 · 0 comments · Fixed by #15
Assignees
@moCello
Labels
fix:bug Something isn't working type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Milestone
Mainnet

Comments

@moCello
Copy link
Member

moCello commented Apr 17, 2024

Summary

Add a way to securely erase sensitive data from memory when types go out of scope.

Possible solution design or implementation

Add Zeroize trait, remove Copy trait on all structs carrying sensitive data.

Additional context

See bls12_381-bls #5
@HDauven HDauven added this to the Mainnet milestone Apr 17, 2024
@HDauven HDauven added fix:bug Something isn't working type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) labels Apr 17, 2024
moCello added a commit that referenced this issue Apr 23, 2024
@moCello
Implement Zeroize for SecretKey
ce3745e 
Resolves #12
@moCello moCello mentioned this issue Apr 23, 2024
Merged
moCello added a commit that referenced this issue Apr 23, 2024
@moCello
Implement Zeroize for SecretKey
d86809f 
Resolves #12
moCello added a commit that referenced this issue Apr 23, 2024
@moCello
Implement Zeroize for SecretKey
7f0d6b9 
Resolves #12
moCello added a commit that referenced this issue Apr 24, 2024
@moCello
Implement Zeroize for SecretKey
e44e1c9 
Resolves #12
moCello added a commit that referenced this issue Apr 24, 2024
@moCello
Implement Zeroize for SecretKey
b07cec8 
Resolves #12
@moCello moCello mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moCello moCello

Labels
fix:bug Something isn't working type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Milestone
Mainnet
Development

Successfully merging a pull request may close this issue.

Implement Zeroize for SecretKey dusk-network/jubjub-schnorr
2 participants
@HDauven @moCello