Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Zeroize for SecretKey #15

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Implement Zeroize for SecretKey #15

merged 1 commit into from
Apr 24, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Apr 23, 2024

Resolves #12

@moCello moCello force-pushed the mocello/12_zeroize branch 3 times, most recently from 7f0d6b9 to e44e1c9 Compare April 24, 2024 14:05
@moCello moCello force-pushed the mocello/12_zeroize branch from e44e1c9 to b07cec8 Compare April 24, 2024 14:11
@moCello moCello requested review from HDauven and ureeves April 24, 2024 14:13
@moCello moCello marked this pull request as ready for review April 24, 2024 14:13
ureeves
ureeves approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with SecretKey::public, but again, not the subject. LGTM

@moCello moCello merged commit b1868f3 into main Apr 24, 2024
9 checks passed
@moCello moCello deleted the mocello/12_zeroize branch April 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@HDauven HDauven Awaiting requested review from HDauven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secret values not erased
2 participants
@moCello @ureeves