Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the re-export of jubjub and bls libs #558

Closed
ZER0 opened this issue Aug 17, 2021 · 0 comments · Fixed by #618
Closed

Remove the re-export of jubjub and bls libs #558

ZER0 opened this issue Aug 17, 2021 · 0 comments · Fixed by #618
Labels
good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)
Milestone
Implementing PlonkUp

Comments

@ZER0
Copy link
Contributor

ZER0 commented Aug 17, 2021

We re-exported the lib because we thought it would be simplify the deps, but after a while we notice is not the case, so the re-exporting should be removed.
@ZER0 ZER0 added good first issue Good for newcomers team:Core Low Level Core Development Team (Rust) labels Aug 17, 2021
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 6, 2021
ZER0 added a commit that referenced this issue Oct 13, 2021
@ZER0
Remove the re-export of jubjub and bls libs
6588e47 
Resolves: #558
@ZER0 ZER0 mentioned this issue Oct 13, 2021
Merged
@ZER0 ZER0 linked a pull request Oct 13, 2021 that will close this issue
Remove the re-export of jubjub and bls libs #618
Merged
ZER0 added a commit that referenced this issue Oct 14, 2021
@ZER0
Remove the re-export of jubjub and bls libs (#618)
21ffc38 
Resolves: #558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
Implementing PlonkUp
Development

Successfully merging a pull request may close this issue.

Remove the re-export of jubjub and bls libs dusk-network/plonk
1 participant
@ZER0