Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the re-export of jubjub and bls libs #618

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

ZER0
Copy link
Contributor

@ZER0 ZER0 commented Oct 13, 2021

Resolves: #558

@ZER0 ZER0 requested review from vlopes11 and ureeves October 13, 2021 16:09
@ZER0 ZER0 linked an issue Oct 13, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #618 (6588e47) into add_lookups (38220d0) will increase coverage by 38.69%.
The diff coverage is 98.95%.

Impacted file tree graph

@@               Coverage Diff                @@
##           add_lookups     #618       +/-   ##
================================================
+ Coverage        59.11%   97.80%   +38.69%     
================================================
  Files               52       53        +1     
  Lines             7183     4103     -3080     
  Branches          2432        0     -2432     
================================================
- Hits              4246     4013      -233     
+ Misses             755       90      -665     
+ Partials          2182        0     -2182     
Impacted Files Coverage Δ
src/commitment_scheme/kzg10/key.rs 98.52% <ø> (+45.56%) ⬆️
src/commitment_scheme/kzg10/proof.rs 100.00% <ø> (+39.53%) ⬆️
src/constraint_system/witness.rs 100.00% <ø> (+8.33%) ⬆️
src/lib.rs 100.00% <ø> (+4.25%) ⬆️
src/plonkup/multiset.rs 98.70% <ø> (+58.03%) ⬆️
src/plonkup/table/lookup_table.rs 97.87% <ø> (+58.98%) ⬆️
src/plonkup/table/preprocess.rs 95.65% <ø> (+72.70%) ⬆️
src/plonkup/table/witness_table.rs 100.00% <ø> (+57.57%) ⬆️
src/proof_system/linearisation_poly.rs 98.90% <ø> (+28.44%) ⬆️
src/proof_system/verifier.rs 84.21% <ø> (+28.94%) ⬆️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2016aa...6588e47. Read the comment docs.

@ZER0 ZER0 merged commit 21ffc38 into add_lookups Oct 14, 2021
@ZER0 ZER0 deleted the remove-re-exports branch October 14, 2021 07:15
vlopes11 pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the re-export of jubjub and bls libs
2 participants