Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plonkup - Add test coverage for polynomial evaluations #586

Closed
vlopes11 opened this issue Sep 27, 2021 · 0 comments · Fixed by #621
Closed

Plonkup - Add test coverage for polynomial evaluations #586

vlopes11 opened this issue Sep 27, 2021 · 0 comments · Fixed by #621
Assignees
@ZER0
Labels
module:plonkup Issue related to plonkup implementation team:Core Low Level Core Development Team (Rust)
Milestone
Implementing PlonkUp

Comments

@vlopes11
Copy link
Contributor

Describe what you want implemented
Currently the new polynomial evaluations for plonkup aren't tested

Describe "Why" this is needed
It is critical to have edge cases and test vectors covered in order to have a robust implementation

Describe alternatives you've considered
N/A

Additional context
N/A
@vlopes11 vlopes11 added team:Core Low Level Core Development Team (Rust) module:plonkup Issue related to plonkup implementation labels Sep 27, 2021
@ZER0 ZER0 self-assigned this Oct 6, 2021
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 6, 2021
ZER0 added a commit that referenced this issue Oct 14, 2021
@ZER0
Add test coverage for polynomial evaluations
9605eb6 
The test vectors are calcolate by @marta-belles, assuming the `ifft`
function is actually correct.

Resolves: #586
@ZER0 ZER0 mentioned this issue Oct 14, 2021
Merged
ZER0 added a commit that referenced this issue Oct 14, 2021
@ZER0
Add test coverage for polynomial evaluations
7f4cd99 
The test vectors are calculate by @marta-belles, assuming the `ifft`
function is actually correct.

Resolves: #586
@ZER0 ZER0 linked a pull request Oct 14, 2021 that will close this issue
Add test coverage for polynomial evaluations #621
Merged
ZER0 added a commit that referenced this issue Oct 14, 2021
@ZER0
Add test coverage for polynomial evaluations
8fe54e1 
The test vectors are calculate by @marta-belles, assuming the `ifft`
function is actually correct.

Resolves: #586
ZER0 added a commit that referenced this issue Oct 15, 2021
@ZER0
Add test coverage for polynomial evaluations (#621)
4769986 
The test vectors are calculate by @marta-belles, assuming the `ifft`
function is actually correct.

Resolves: #586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZER0 ZER0

Labels
module:plonkup Issue related to plonkup implementation team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
Implementing PlonkUp
Development

Successfully merging a pull request may close this issue.

Add test coverage for polynomial evaluations dusk-network/plonk
2 participants
@ZER0 @vlopes11