Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for polynomial evaluations #621

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Add test coverage for polynomial evaluations #621

merged 1 commit into from
Oct 15, 2021

Conversation

ZER0
Copy link
Contributor

@ZER0 ZER0 commented Oct 14, 2021

The test vectors are calculate by @marta-belles, assuming the ifft
function is actually correct.

Resolves: #586

The test vectors are calculate by @marta-belles, assuming the `ifft`
function is actually correct.

Resolves: #586
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #621 (30dd939) into add_lookups (38220d0) will increase coverage by 38.57%.
The diff coverage is 99.12%.

❗ Current head 30dd939 differs from pull request most recent head 8fe54e1. Consider uploading reports for the commit 8fe54e1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           add_lookups     #621       +/-   ##
================================================
+ Coverage        59.11%   97.68%   +38.57%     
================================================
  Files               52       54        +2     
  Lines             7183     4111     -3072     
  Branches          2432        0     -2432     
================================================
- Hits              4246     4016      -230     
+ Misses             755       95      -660     
+ Partials          2182        0     -2182     
Impacted Files Coverage Δ
src/commitment_scheme/kzg10/key.rs 98.53% <ø> (+45.57%) ⬆️
src/commitment_scheme/kzg10/proof.rs 100.00% <ø> (+39.53%) ⬆️
src/constraint_system/witness.rs 100.00% <ø> (+8.33%) ⬆️
src/lib.rs 100.00% <ø> (+4.25%) ⬆️
src/plonkup/multiset.rs 98.70% <ø> (+58.03%) ⬆️
src/plonkup/table/lookup_table.rs 97.87% <ø> (+58.98%) ⬆️
src/plonkup/table/preprocess.rs 95.65% <ø> (+72.70%) ⬆️
src/plonkup/table/witness_table.rs 100.00% <ø> (+57.57%) ⬆️
src/proof_system/linearisation_poly.rs 98.90% <ø> (+28.44%) ⬆️
src/proof_system/verifier.rs 85.00% <ø> (+29.73%) ⬆️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ffc38...8fe54e1. Read the comment docs.

Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZER0 ZER0 merged commit 4769986 into add_lookups Oct 15, 2021
@ZER0 ZER0 deleted the test-perm branch October 15, 2021 09:25
vlopes11 pushed a commit that referenced this pull request Oct 18, 2021
The test vectors are calculate by @marta-belles, assuming the `ifft`
function is actually correct.

Resolves: #586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plonkup - Add test coverage for polynomial evaluations
3 participants